Improve escaping of byte, byte str, and c str proc-macro literals#123769
Merged
bors merged 3 commits intorust-lang:masterfrom Jun 14, 2024
Merged
Improve escaping of byte, byte str, and c str proc-macro literals#123769bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
proc_macro::Literal::byte_character(#115268),byte_string, andc_string(#119750) to improve their choice of escape sequences. 3 categories of changes are made:Never use
\x00. Always prefer\0, which is supported in all the same places.Never escape
\'inside double quotes and\"inside single quotes.Never use
\xfor valid UTF-8 in literals that permit\u.The second commit adds tests covering these cases, asserting the old behavior.
The third commit implements the behavior change and simultaneously updates the tests to assert the new behavior.